Browse Source

Adding comments

f 5 years ago
parent
commit
0e6b89ac20
1 changed files with 12 additions and 0 deletions
  1. 12 0
      src/lib.rs

+ 12 - 0
src/lib.rs

@@ -296,6 +296,13 @@ impl members::Trait for Runtime {
 
 /*
  * Forum module integration
+ * 
+ * ForumUserRegistry could have been implemented directly on 
+ * the membership module, and likewise ForumUser on Profile,
+ * however this approach is more loosley coupled.
+ * 
+ * Further exploration required to decide what the long
+ * run convention should be.
  */
 
 /// Shim registry which will proxy ForumUserRegistry behaviour to the members module
@@ -307,6 +314,11 @@ impl forum::ForumUserRegistry<AccountId> for ShimMembershipRegistry {
 
         if let Some(profile) = members::Module::<Runtime>::get_profile(id) {
 
+            // For now the profile is not used for anything,
+            // but in the future we may need it to read out more
+            // information possibly required to construct a 
+            // ForumUser.
+
             // Now convert member profile to a forum user
             Some(forum::ForumUser{
                 id: id.clone()