runtime: engine: remove obsolete test and error

runtime-modules/proposals/engine/src/lib.rs

@@ -312,9 +312,6 @@ decl_error! {
         /// Proposal is finalized already
         ProposalFinalized,
 
-        /// Proposal is not pending execution
-        ProposalNotPendingExecution,
-
         /// The proposal have been already voted on
         AlreadyVoted,
 

runtime-modules/proposals/engine/src/tests/mod.rs

@@ -1190,60 +1190,6 @@ fn cancel_pending_constitutionality_proposal_by_runtime() {
     });
 }
 
-#[test]
-fn proposal_execution_vetoed_successfully_during_the_grace_period() {
-    initial_test_ext().execute_with(|| {
-        let starting_block = 1;
-        run_to_block(starting_block);
-
-        let parameters_fixture = ProposalParametersFixture::default().with_grace_period(3);
-        let dummy_proposal =
-            DummyProposalFixture::default().with_parameters(parameters_fixture.params());
-
-        let proposal_id = dummy_proposal.create_proposal_and_assert(Ok(1)).unwrap();
-
-        let mut vote_generator = VoteGenerator::new(proposal_id);
-        vote_generator.vote_and_assert_ok(VoteKind::Approve);
-        vote_generator.vote_and_assert_ok(VoteKind::Approve);
-        vote_generator.vote_and_assert_ok(VoteKind::Approve);
-        vote_generator.vote_and_assert_ok(VoteKind::Approve);
-
-        run_to_block(3);
-
-        let pre_veto_proposal = <crate::Proposals<Test>>::get(proposal_id);
-
-        assert_eq!(
-            pre_veto_proposal,
-            Proposal {
-                parameters: parameters_fixture.params(),
-                proposer_id: 1,
-                activated_at: starting_block,
-                status: ProposalStatus::approved(
-                    ApprovedProposalDecision::PendingExecution,
-                    starting_block + 1
-                ),
-                voting_results: VotingResults {
-                    abstentions: 0,
-                    approvals: 4,
-                    rejections: 0,
-                    slashes: 0,
-                },
-                exact_execution_block: None,
-                nr_of_council_confirmations: 1,
-                staking_account_id: None,
-            }
-        );
-
-        let veto_proposal = VetoProposalFixture::new(proposal_id);
-        veto_proposal.veto_and_assert(Ok(()));
-
-        EventFixture::assert_last_crate_event(RawEvent::ProposalDecisionMade(
-            proposal_id,
-            ProposalDecision::Vetoed,
-        ));
-    });
-}
-
 #[test]
 fn proposal_execution_succeeds_after_the_grace_period() {
     initial_test_ext().execute_with(|| {

runtime/src/proposals_configuration/tests.rs

@@ -233,7 +233,7 @@ fn proposal_parameters_are_initialized_unlock_blog_post_proposal() {
 #[test]
 #[ignore]
 fn proposal_parameters_are_initialized_veto_proposal_proposal() {
-    let actual_params = super::UnlockBlogPostProposalParameters::get();
+    let actual_params = super::VetoProposalProposalParameters::get();
 
     assert_eq!(default_proposal_parameters(), actual_params);
 }