Browse Source

Merge pull request #1236 from Lezek123/proposal-error-hotfix

Proposal error message hotfix
Mokhtar Naamani 4 years ago
parent
commit
d6f6eb5e21

+ 1 - 1
pioneer/packages/joy-proposals/src/Proposal/ProposalDetails.tsx

@@ -99,7 +99,7 @@ export function getExtendedStatus (proposal: ParsedProposal, bestNumber: BlockNu
         if (approvedStatus === 'ExecutionFailed') {
           const executionFailedStatus = proposalStatus.asType('Approved').asType('ExecutionFailed');
 
-          executionFailReason = Buffer.from(executionFailedStatus.error.toString().replace('0x', ''), 'hex').toString();
+          executionFailReason = executionFailedStatus.error.toString();
         }
       }
     }

+ 1 - 1
types/augment/all/defs.json

@@ -852,7 +852,7 @@
         }
     },
     "ExecutionFailed": {
-        "error": "Vec<u8>"
+        "error": "Text"
     },
     "Approved": {
         "_enum": {

+ 1 - 1
types/augment/all/types.ts

@@ -466,7 +466,7 @@ export interface EntryMethod extends Enum {
 
 /** @name ExecutionFailed */
 export interface ExecutionFailed extends Struct {
-  readonly error: Bytes;
+  readonly error: Text;
 }
 
 /** @name ExitedLeadRole */

+ 1 - 1
types/src/proposals.ts

@@ -86,7 +86,7 @@ export class ActiveStake extends JoyStructDecorated({ stake_id: StakeId, source_
   implements IActiveStake {}
 
 export class ExecutionFailedStatus extends JoyStructDecorated({
-  error: Vec.with(u8),
+  error: Text,
 }) {}
 
 export class ExecutionFailed extends ExecutionFailedStatus {}